Skip to content

Commit

Permalink
Using Utils.BuildArguments to create arguments string for MSI install…
Browse files Browse the repository at this point in the history
…er causes issues so reverted that change. This fixes #664.
  • Loading branch information
ravibpatel committed Feb 15, 2024
1 parent 1251544 commit 8e87884
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions AutoUpdater.NET/DownloadUpdateDialog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -230,18 +230,11 @@ private void WebClientOnDownloadFileCompleted(object sender, AsyncCompletedEvent
FileName = "msiexec"
};

var arguments = new Collection<string>
{
"/i",
tempPath
};

processStartInfo.Arguments = $"/i \"{tempPath}\"";
if (!string.IsNullOrEmpty(installerArgs))
{
arguments.Add(installerArgs);
processStartInfo.Arguments += $" {installerArgs}";
}

processStartInfo.Arguments = Utils.BuildArguments(arguments);
}

if (AutoUpdater.RunUpdateAsAdmin)
Expand Down

0 comments on commit 8e87884

Please sign in to comment.