-
Notifications
You must be signed in to change notification settings - Fork 210
(android) added bannerHeight to banner LOAD event (#361) #373
base: master
Are you sure you want to change the base?
Conversation
Hi, any progress on this? |
please merge this fix!! it's extremely helpful! |
please merge.. I need it |
What does it help with? |
having the height in the LOAD event is very useful since the height varies, it saves doing unnecessary calculations for the layout after the the banner is loaded |
|
||
data.put("bannerHeight", heightDp); | ||
} catch (JSONException e) { | ||
e.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if this propagates to the webview console too.
Hi, needed also here. I have a jquery cordova app that needs to be properly resized and if banner is shown I loose bottom buttons... |
Any progress on this? |
Just noticed if I test on a device running API 30 or API R the banner height that gets returned is actually the device height (so in this case 14400) - is it just me or are others seeing the same issue? Any ideas?
|
Same change implemented on android