-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implementation of KMP CRL revocation factory with cache #1900
Conversation
since the prev PR got merged, we can switch the target branch to dev. |
As discussed, I can keep target as feature branch till we have e2e ready. |
As discussed, I would include the |
As discussed, I would include the
Done |
pkg/keymanagementprovider/azurekeyvault/kmprevocationfactory.go
Outdated
Show resolved
Hide resolved
pkg/keymanagementprovider/azurekeyvault/kmprevocationfactory.go
Outdated
Show resolved
Hide resolved
pkg/keymanagementprovider/azurekeyvault/kmprevocationfactory.go
Outdated
Show resolved
Hide resolved
pkg/keymanagementprovider/azurekeyvault/kmprevocationfactory.go
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
|
ec10822
to
b617d59
Compare
Signed-off-by: Juncheng Zhu <[email protected]>
b617d59
to
dfd6adf
Compare
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Description
What this PR does / why we need it:
Enabled load CRLs from all types of KMP provider, both inline KMP and akv KMP.
Optimized CRL core functions and the Implementation of CRL Handler, CRL Handler is now the only implementation of the CRL interface and being reused by notation verifier and KMP.
Added description to the interface definition and more comments to the codebase.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1901
Optimize CRL interface and core functions:
Implementation of CRL Handler
Design Doc: https://github.com/ratify-project/ratify/blob/dev/docs/design/Certificate%20Revocation%20Lists.md
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
CI test
Checklist:
Post Merge Requirements
Helm Chart Change