Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReportMetrics to azureidentity.go #1868

Open
shahramk64 opened this issue Oct 15, 2024 · 5 comments
Open

Add ReportMetrics to azureidentity.go #1868

shahramk64 opened this issue Oct 15, 2024 · 5 comments
Assignees

Comments

@shahramk64
Copy link
Contributor

ReportMetrics is already used in azureqorkloadidentity.go. To provide parity between the two auth providers, ReportMetrics should be added to azureidentity.go too.

@SpongeBob0318
Copy link

/assign

@shahramk64
Copy link
Contributor Author

@SpongeBob0318 Thanks for working on this issue. It seems like you closed the PR, do you need any help to continue your work so you can make this PR ready to merge?

@SpongeBob0318
Copy link

@SpongeBob0318感谢您处理此问题。您似乎关闭了 PR,您需要任何帮助来继续您的工作,以便让此 PR 准备好合并吗?

I'm not sure if my modifications are correct, Codecov was unsuccessful when I submitted the PR

@shahramk64
Copy link
Contributor Author

@SpongeBob0318 I'll add some comments on your PR on how you can pass Codecov action.

@SpongeBob0318
Copy link

@SpongeBob0318 I'll add some comments on your PR on how you can pass Codecov action.

thank you, i have reopen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants