-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ReportMetrics to azureidentity.go #1870
Conversation
Codecov ReportAttention: Patch coverage is
|
@SpongeBob0318 thanks for making the PR! Could you fix the lint error and update the title to follow conventional commit spec?
|
Signed-off-by: wang jiabao <[email protected]>
@SpongeBob0318 Codecov fails because we now have a requirement that new PRs should have %80 coverage for unit testing. You need to define unit tests and make sure they pass on your PR. |
great , i'll try |
Updated issue link |
@SpongeBob0318 Hey, are you still interested in continuing the work on this PR? |
This is out of date with Dev branch, and conflicts needs to be resolved. Please reopen PR once we have capacity. |
邮件已收到————————————这是来自QQ邮箱的自动回复邮件。
|
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1868
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change