PMT Factory changes to accomodate mesh generation. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes modifications to the PMT Factories that allows triangulated geometries to be more easily generated:
There exist a "gap" volume in the PMT factories to avoid volume overlaps between the two inner volumes (one covered by photocathode, the other covered in mirror). This gap results in cylinders of very small height, resulting in numerical precision issues during mesh generation. The gap width is adjusted from 1e-07 to 1e-03 mm such that it is small enough to not greatly alter the PMT geometry, but alleviates the precision issues.
The revolution PMT geometry currently has overlap issues if no datapoint is specifically set at z=0, since there is no check in Z coordinate position when the inner volume is split in half. A check is added to insert an interpolated datapoint at z=0, if needed.