Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Branding, URLs #771

Open
wants to merge 5 commits into
base: qml
Choose a base branch
from

Conversation

tdewey-rpi
Copy link
Collaborator

raspberrypi.org is owned by the Raspberry Pi Foundation, and for cleanliness, we should point instead to raspberrypi.com (which is run by Raspberry Pi Ltd) instead.

Additionally, let's make sure the application name reflects the...application name! "Imager" was unfortunately a little too short to distinguish from tools included in various Linux distros, and avoiding confusion is the aim.

@tdewey-rpi tdewey-rpi requested a review from maxnet January 5, 2024 10:48
@tdewey-rpi
Copy link
Collaborator Author

Not safe to merge yet - turns out QSettings uses the name as the config file name, so we'll need a way to either compel QSettings back to using the previous name or a migration mechanism that is reliable.

@tdewey-rpi tdewey-rpi marked this pull request as draft January 5, 2024 16:05
@tdewey-rpi tdewey-rpi force-pushed the meta/branding-and-urls branch from 0bb43f3 to a160132 Compare January 5, 2024 16:13
@tdewey-rpi tdewey-rpi marked this pull request as ready for review January 5, 2024 16:17
@tdewey-rpi tdewey-rpi requested a review from cillian64 January 5, 2024 16:17
@maxnet
Copy link
Collaborator

maxnet commented Jan 5, 2024

There may be other places where .org and the original application name (imagingutility) is used, like "mac/Info.plist.in"

I am always a bit hesitant with changing such things though...
In addition to saved configuration settings no longer working, changing application identifiers is likely to void system settings like file associations, granted permissions (whether or not the program is allowed to access removable media on Mac) and may affect any white-listing we may have in anti-virus/corporate security programs.

Copy link
Collaborator

@cillian64 cillian64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that some care is needed, but the name change in the linux .desktop file shouldn't affect file associations, and we're not changing the executable name or config file name/location.

@maxnet
Copy link
Collaborator

maxnet commented Jan 10, 2024

Agreed that some care is needed, but the name change in the linux .desktop file shouldn't affect file associations

Wasn't too concerned about the .desktop file.

    _app->setOrganizationDomain("raspberrypi.com");
    _app->setApplicationName("Raspberry Pi Imager");

But for example the application name set here is used at several less obvious places like in DBus communication.

If you also would change the Mac plist it also do could affect things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants