-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Branding, URLs #771
base: qml
Are you sure you want to change the base?
Conversation
Not safe to merge yet - turns out QSettings uses the name as the config file name, so we'll need a way to either compel QSettings back to using the previous name or a migration mechanism that is reliable. |
0bb43f3
to
a160132
Compare
There may be other places where .org and the original application name (imagingutility) is used, like "mac/Info.plist.in" I am always a bit hesitant with changing such things though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that some care is needed, but the name change in the linux .desktop file shouldn't affect file associations, and we're not changing the executable name or config file name/location.
Wasn't too concerned about the .desktop file.
But for example the application name set here is used at several less obvious places like in DBus communication. If you also would change the Mac plist it also do could affect things. |
raspberrypi.org is owned by the Raspberry Pi Foundation, and for cleanliness, we should point instead to raspberrypi.com (which is run by Raspberry Pi Ltd) instead.
Additionally, let's make sure the application name reflects the...application name! "Imager" was unfortunately a little too short to distinguish from tools included in various Linux distros, and avoiding confusion is the aim.