Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration/config-txt/memory.md - minor fixup #1610

Merged
merged 14 commits into from Jul 7, 2020
Merged

configuration/config-txt/memory.md - minor fixup #1610

merged 14 commits into from Jul 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2020

There's an 8GB Pi 4 now. Reword things slightly, and don't enumerate each model of Pi 4. The intention is to make the opening paragraph read simpler, and perhaps make future maintenance of the page slightly easier.

andrum99 added 6 commits July 5, 2020 12:17
Give recommended maximums instead - that's what 99% of users actually need from the documentation.
@JamesH65
Copy link
Contributor

JamesH65 commented Jul 6, 2020

I'd be inclined to really emphasise that the use of large values for gpu_mem can actually stop the device booting, also emphasis that increasing it does NOT increase performance.

@ghost
Copy link
Author

ghost commented Jul 6, 2020

I've address the review comments. The page says the default is 64 but on my systems I'm seeing a default of 76MB now, but I'm not sure if this is Pi 4-specific.

@ghost
Copy link
Author

ghost commented Jul 6, 2020

OK, this one should be ready to roll now, except for the query re default.

@ghost
Copy link
Author

ghost commented Jul 6, 2020

It seems the default is now 76MB on all devices. I've filed RPi-Distro/raspi-config#122 to have raspi-config fixed accordingly.

@ghost
Copy link
Author

ghost commented Jul 6, 2020

It seems the default is now 76MB on all devices. I've filed RPi-Distro/raspi-config#122 to have raspi-config fixed accordingly.

Actually it's just Pi 2 and later. I don't have a Zero to hand to test, but from memory it is 64MB on that as well.

@JamesH65
Copy link
Contributor

JamesH65 commented Jul 7, 2020

LGTM @lurch?

@lurch
Copy link
Contributor

lurch commented Jul 7, 2020

Might be useful to get feedback from @spl237 or @popcornmix about the default gpu_mem value?

@ghost
Copy link
Author

ghost commented Jul 7, 2020

Might be useful to get feedback from @spl237 or @popcornmix about the default gpu_mem value?

Good idea. Is there a 1GB Pi 1? It might be related to memory size rather than SoC.

@popcornmix
Copy link
Contributor

There are no 1GB Pi0/Pi1 devices.

@popcornmix
Copy link
Contributor

default gpu_mem is 76 for 1GB (or greater) and 64 for less.

@ghost
Copy link
Author

ghost commented Jul 7, 2020

default gpu_mem is 76 for 1GB (or greater) and 64 for less.

Thanks for the clarification. The page should now be ready to go.

@JamesH65 JamesH65 merged commit a7d4b11 into raspberrypi:master Jul 7, 2020
@ghost ghost deleted the patch-1 branch August 13, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants