Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of gpu_mem to match raspi-config #50

Closed
wants to merge 5 commits into from
Closed

Fix handling of gpu_mem to match raspi-config #50

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2020

rc_gui currently handles setting gpu_mem slightly differently to raspi-config:

  • If there is no gpu_mem specified in config.txt, raspi-config will assume the default gpu_mem setting of 64MB
    (PR Fix default gpu_mem for boards with >=1GB RAM RPi-Distro/raspi-config#131 pending to change this to the actual firmware default of 64 or 76MB, which depends on memory size)
  • If there is no gpu_mem specified in config.txt, rc_gui will call vcgencmd get_mem gpu and default to that

The rc_gui version of the algorithm suffers from a minor problem (apart from the fact it doesn't match raspi-config): if the user has previously booted with a gpu_mem setting in config.txt (for example 320MB), then removed that line (perhaps using a previous run of rc_gui), then run rc_gui, it will prompt the user with a "default" of e.g. 320MB, not what the firmware actually defaults to in the case of nothing being specified in config.txt, i.e. 64 or 76MB. This PR fixes up rc_gui so that it behaves the same as raspi-config with RPi-Distro/raspi-config#131 applied.

@ghost
Copy link
Author

ghost commented Sep 2, 2020

Also added some extras to the README to document some packages I needed to install before I could build it on my Pi 4B.

@spl237 spl237 closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants