Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PENDED - Splitting into separate PRs #1346

Closed
wants to merge 38 commits into from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Sep 5, 2023

Details:

  • Adds two new Test Tables (One without Primary Key, one without $model or builder()) and relevant tests
  • Missing Pagination test
  • Improves Injection Test Coverage
  • Adds FormattedContents Test
  • Adds Filter Pills Blade Test
  • Add setSearchFieldAttributes() and getSearchFieldAttributes()
  • Add setFilterPopoverAttributes() and getFilterPopoverAttributes()

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1346 (03d31d2) into v3-develop (74b547c) will increase coverage by 0.33%.
The diff coverage is 70.21%.

@@               Coverage Diff                @@
##             v3-develop    #1346      +/-   ##
================================================
+ Coverage         86.11%   86.44%   +0.33%     
- Complexity         1138     1146       +8     
================================================
  Files                83       83              
  Lines              2780     2774       -6     
================================================
+ Hits               2394     2398       +4     
+ Misses              386      376      -10     
Files Changed Coverage Δ
src/Mechanisms/RappasoftFrontendAssets.php 51.11% <0.00%> (+4.17%) ⬆️
src/Traits/ComponentUtilities.php 90.00% <ø> (ø)
src/Traits/WithSearch.php 100.00% <ø> (ø)
src/Traits/Configuration/FilterConfiguration.php 94.00% <100.00%> (+0.38%) ⬆️
src/Traits/Configuration/SearchConfiguration.php 86.20% <100.00%> (+0.75%) ⬆️
src/Traits/Helpers/FilterHelpers.php 76.74% <100.00%> (+0.36%) ⬆️
src/Traits/Helpers/SearchHelpers.php 98.14% <100.00%> (+0.07%) ⬆️
...rc/Traits/Mechanisms/WithRappasoftTableScripts.php 75.00% <100.00%> (-2.78%) ⬇️
src/Traits/Mechanisms/WithRappasoftTableStyles.php 77.77% <100.00%> (-3.18%) ⬇️
...Mechanisms/WithRappasoftTableThirdPartyScripts.php 81.81% <100.00%> (-2.19%) ⬇️
... and 4 more

... and 2 files with indirect coverage changes

@lrljoe lrljoe changed the title Add Exception Tests Add Tests - Exceptions & Injection Sep 5, 2023
@lrljoe lrljoe changed the title Add Tests - Exceptions & Injection PENDED - Splitting into separate PRs Sep 21, 2023
@lrljoe lrljoe closed this Oct 5, 2023
@lrljoe lrljoe deleted the lrl-v3-develop branch October 31, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant