-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chinese Version #27
base: master
Are you sure you want to change the base?
Chinese Version #27
Conversation
Thanks for your interest! I took a quick look at your contribution. Good Job. I've been thinking about adding i18n support for a long time but failed to find time to do that. And you're going in the right direction by replacing hardcoded text with text from loaded files. And here are some feedbacks:
BTW, I've seen some mistakes in your translation. Are you using a web translator? I would say it's not very satisfying. Maybe there are some words misspelled in the original README. I don't have much time for the review because of the upcoming exams. So my reply maybe delayed. Thanks. |
Yes, I am using a web translator, plus a little bit of my own understanding. And can the feedbacks be more detailed? Thanks. |
…lease place them in a separate PR.'
Sorry for the delay! I've forgotten this stuff 🤡🤡🤡 Your PR looks good and need a little improvement as pointed out. |
I see the fix of #28 is still in this PR. Can you cherry-pick that and open a separate PR? If you don't have time, I can do that :) |
OK |
A little contribution :)