-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ubuntu 24.04 in CI workflows. #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started. I left one suggestion for your consideration.
…untu 22.04 instead of 24.04 on CUDA versions older than 12.5.1 (not supported by CUDA).
Some notes:
|
CI testing is complete! Here is the link: rapidsai/build-planning#74 (comment) Are there any other repositories we should test? I think I got sufficient coverage here, and am happy to help iron out any additional issues that arise after merging. |
For future record, there were a couple of minor hiccups:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm happy with the matrix changes (they look identical to what I'd previously reviewed) and with the extent of the testing that was done.
I support merging this as-is, will defer to your judgment on the timing.
I'm going to merge. If any issues arise, we have plenty of time to fix them before burndown or code freeze for 24.12. |
This PR replaces
ubuntu22.04
withubuntu24.04
. This allows us to continue testing endpoints of our support matrix (we still support Ubuntu 20.04). The CI matrix has been reduced enough that I do not see a significant value proposition to keep any jobs with Ubuntu 22.04. It seems more valuable to have extensive testing of Ubuntu 24.04.Depends on rapidsai/ci-imgs#195.
Contributes to rapidsai/build-planning#74.