-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify wheel CI scripts, other small packaging changes #6190
simplify wheel CI scripts, other small packaging changes #6190
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
/ok to test |
/ok to test |
dependencies.yaml
Outdated
@@ -142,9 +173,7 @@ dependencies: | |||
- cxx-compiler | |||
- fmt>=11.0.2,<12 | |||
- libcumlprims==25.2.*,>=0.0.0a0 | |||
- libcuvs==25.2.*,>=0.0.0a0 | |||
- libraft-headers==25.2.*,>=0.0.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move/remove libcumlprims
and libraft-headers
into their own depends_on_X
lists. Or maybe we can remove libraft-headers
here? We did that in cugraph, iirc. This is not a blocker, I defer to your judgment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to remove libraft-headers
here. That was fine in rapidsai/cugraph#4805 (comment) because there, it was coming through transitively via libraft
.
cuml
's environments and conda recipes don't depend on libraft
, so I think it's still needed here.
I just pushed b9a0bb0 moving libcumlprims
and libraft-headers
into depends_on lists. They were only used once so it doesn't remove any duplication today, but it's helpful for applying this depends_on convention consistently across RAPIDS, and keeps the diff of a future change using those packages in more places smaller.
I'll merge this once CI passes.
4d51566
to
b9a0bb0
Compare
CI here is failing with this dask-related issue:
That should have been fixed by rapidsai/rapids-dask-dependency#77. But for some reason CI here is not picking up the newest Trying one more re-run of CI. If that fails, I'll investigate why conda isn't choosing that newer |
@jameslamb We have had to purge old alpha builds of rapids-dask-dependency several times in the past when the dask pinnings have changed. In those situations, the solver was preferring an older rapids-dask-dependency build with a different dask pinning for unclear reasons. We may need to do that again. |
Ok yeah sounds good @bdice , I'll go ask for that. By the way, I think CI here will now also be blocked until #6187 is merged. Seeing this in wheel builds:
Which I think is a result of rapidsai/raft#2530 being merged about an hour ago. |
Ah yes unfortunately that is correct. I figured today was a fairly low-impact day to start merging those since most people are off. I'm currently waiting for the latest raft builds to deploy, then I'll merge the corresponding cuvs PR, then the cuml one. |
Yep all good! Thanks for keeping that rapids-logger stuff moving, I definitely think the bumps along the way will be worth it for the end state it gets us to. |
/merge |
Fixes #6023
Proposes some miscellaneous packaging cleanup:
rapids-dependency-file-generator
to its latest version (1.17.0) in pre-commit configPACKAGE_CUDA_SUFFIX
inbuild_wheel.sh
pip install cmake
intest_wheel.sh
treelite
wheels now: https://pypi.org/project/treelite/#filesBUILD_PRIMS_BENCH OFF
, removesBUILD_BENCH OFF
inget_raft.cmake
(matching changes to RAFT from 23.04: Add end-to-end CUDA ann-benchmarks to raft raft#1304)BUILD_CUML_PRIMS_BENCH
(nothing uses this)CUML_USE_FAISS_STATIC
(nothing uses this)dependencies.yaml
changes:depends_on_*
groups to reduce duplication, and for consistency with other RAPIDS projects (docs explaining this)