Skip to content

Commit

Permalink
Narrow scope since the logger is only needed in kmeans because cuml i…
Browse files Browse the repository at this point in the history
…s reexporting cuvs types that depend on raft types.
  • Loading branch information
vyasr committed Dec 19, 2024
1 parent 0b26227 commit 6306661
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ if(BUILD_CUML_CPP_LIBRARY)
)

target_link_libraries(${CUML_CPP_TARGET}
PUBLIC rmm::rmm rmm::rmm_logger raft::raft_logger ${CUVS_LIB}
PUBLIC rmm::rmm rmm::rmm_logger ${CUVS_LIB}
${_cuml_cpp_public_libs}
PRIVATE ${_cuml_cpp_private_libs}
)
Expand Down
5 changes: 3 additions & 2 deletions python/cuml/cuml/cluster/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# =============================================================================
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
# in compliance with the License. You may obtain a copy of the License at
Expand Down Expand Up @@ -29,7 +29,8 @@ add_subdirectory(hdbscan)
rapids_cython_create_modules(
CXX
SOURCE_FILES "${cython_sources}"
LINKED_LIBRARIES "${cuml_mg_libraries}"
# Need the raft logger to specify enum types for the kmeans parameters.
LINKED_LIBRARIES "${cuml_mg_libraries}" raft::raft_logger
MODULE_PREFIX cluster_
ASSOCIATED_TARGETS cuml
)
1 change: 1 addition & 0 deletions python/cuml/cuml/cluster/kmeans_utils.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ cdef extern from "cuml/cluster/kmeans.hpp" namespace \
"cuvs::cluster::kmeans::params":
enum InitMethod:
KMeansPlusPlus, Random, Array

cdef extern from "raft/core/logger.hpp" namespace "raft":
cdef enum class level_enum:
trace
Expand Down

0 comments on commit 6306661

Please sign in to comment.