Fix DataFrame.sort_index when a index is a MultiIndex
#14621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
galipremsagar
requested review from
bdice,
isVoid and
mroeschke
and removed request for
a team
bdice
approved these changes
Dec 13, 2023
mroeschke
reviewed
Dec 13, 2023
| condition=axis in (1, "columns") | ||
| and ignore_index | ||
| and not (level is None and not ascending), | ||
| reason="https://github.com/pandas-dev/pandas/issues/56478", |
There was a problem hiding this comment.
Should hopefully be fixed in pandas 2.2: pandas-dev/pandas#56487
mroeschke
approved these changes
Dec 13, 2023
galipremsagar
added
5 - Ready to Merge
galipremsagar
merged commit 72221b3
into
rapidsai:pandas_2.0_feature_branch
19 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes sorting of a MultiIndex by removing an existing hard-coded
na_positionvalue that was based onascendingflag, essentially ignoring the user-passed parameter.On
pandas_2.0_feature_branch:This PR:
Checklist