Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing input object when calling init_tab_complete #19711

Conversation

sjanusz-r7
Copy link
Contributor

@sjanusz-r7 sjanusz-r7 commented Dec 10, 2024

This PR changes the input class used by the Driver to be Rex Readline instead of Rex Stdio.
It also changes the init_tab_complete method to no longer overwrite the currently existing self.input object but to instead reset its tab completion.

The original code originated around 2005, with no reason given as to why init_tab_complete would need to overwrite the Stdio object with Readline.new(lambda ...). This also fixes the scenario of the self.input object being overwritten if passed in as an option to the Driver constructor and then calling the init_tab_complete method.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • Ensure you can use the console as expected
  • Ensure tab completion works as expected
  • CI passes

@dwelch-r7 dwelch-r7 self-assigned this Dec 11, 2024
@dwelch-r7 dwelch-r7 merged commit 65612d6 into rapid7:master Dec 11, 2024
37 checks passed
@dwelch-r7 dwelch-r7 added the rn-fix release notes fix label Dec 11, 2024
@dwelch-r7 dwelch-r7 added rn-no-release-notes no release notes and removed rn-fix release notes fix labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-no-release-notes no release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants