Use existing input object when calling init_tab_complete #19711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the input class used by the Driver to be Rex Readline instead of Rex Stdio.
It also changes the
init_tab_complete
method to no longer overwrite the currently existingself.input
object but to instead reset its tab completion.The original code originated around 2005, with no reason given as to why
init_tab_complete
would need to overwrite theStdio
object withReadline.new(lambda ...)
. This also fixes the scenario of theself.input
object being overwritten if passed in as an option to the Driver constructor and then calling theinit_tab_complete
method.Verification
List the steps needed to make sure this thing works
msfconsole