Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set readline output to non-prompting on method exit #19710

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

szymonj99
Copy link
Contributor

@szymonj99 szymonj99 commented Dec 9, 2024

This PR sets the output to be non-prompting after the pgets method exits. This follows other examples in the codebase and seems like a sane thing to do.

Verification

  • Start msfconsole
  • Get a session
  • Ensure calling sessions -i -1 works as expected
  • Ensure you can background the session
  • Ensure user input to the console in the session and Console contexts works as expected
  • Ensure CI passes

@smcintyre-r7
Copy link
Contributor

Does this fix some kind of a bug you ran into or are you just trying to align it with the other examples in the code base?

@smcintyre-r7 smcintyre-r7 self-assigned this Dec 10, 2024
@smcintyre-r7 smcintyre-r7 merged commit c3cf56f into rapid7:master Dec 11, 2024
37 checks passed
@smcintyre-r7 smcintyre-r7 added the rn-no-release-notes no release notes label Dec 11, 2024
@szymonj99 szymonj99 deleted the set-prompitng-false branch December 11, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-no-release-notes no release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants