Clarify documentation in dns_txt_query_exec #19703
Merged
+71
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some major changes to the module information for the
windows/dns_txt_query_exec
module to help clarify how it works for users. I also clarified a couple of key comments in the shellcode to document that the returned struct is aDNS_TXT_DATAA
instance and that it's checking the number of strings in that field. I ran into this while debugging the payload to figure out why it wasn't working.Verification
I recommend reviewing while ignoring whitespace. There were a lot of tabs that were breaking the indentation of the shellcode comments.
This PR makes no functional changes, nothing in the shellcode other than comments and whitespace should have changed so it shouldn't be necessary to test it again.