Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation in dns_txt_query_exec #19703

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

zeroSteiner
Copy link
Contributor

@zeroSteiner zeroSteiner commented Dec 6, 2024

This makes some major changes to the module information for the windows/dns_txt_query_exec module to help clarify how it works for users. I also clarified a couple of key comments in the shellcode to document that the returned struct is a DNS_TXT_DATAA instance and that it's checking the number of strings in that field. I ran into this while debugging the payload to figure out why it wasn't working.

Verification

I recommend reviewing while ignoring whitespace. There were a lot of tabs that were breaking the indentation of the shellcode comments.

  • Read through the module description and have a better understanding of what the payload is doing
  • Read through the shellcode and understand what it's doing

This PR makes no functional changes, nothing in the shellcode other than comments and whitespace should have changed so it shouldn't be necessary to test it again.

@adfoster-r7 adfoster-r7 merged commit 8618591 into rapid7:master Dec 7, 2024
70 checks passed
@adfoster-r7 adfoster-r7 added the rn-enhancement release notes enhancement label Dec 7, 2024
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Dec 7, 2024

Release Notes

Adds additional documentation to the windows/dns_txt_query_exec module to help clarify how it works for users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants