Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query param in reconfig_redirect_opts! #19700

Merged
merged 2 commits into from
Dec 11, 2024
+5 −1
Merged

Fix query param in reconfig_redirect_opts! #19700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a544805
Fix query in reconfig_redirect_opts!
jheysel-r7 Dec 6, 2024
c7b96f8
Unset opts query if no location.query
jheysel-r7 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/msf/core/exploit/remote/http_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,11 @@ def reconfig_redirect_opts!(res, opts)
end

# Don't forget any GET parameters
opts['query'] ||= location.query if location.query
if location.query
opts['query'] = location.query
else
opts['query'] = ''
end
Comment on lines +502 to +506
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if location.query
opts['query'] = location.query
else
opts['query'] = ''
end
opts['query'] = location.query

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we default to '' in the bowels of rex, not a blocker

metasploit-framework/lib/rex/proto/http/client_request.rb

Line 31 in c3cf56f

'query' => '',

end

#
Expand Down
Loading