Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obsidian community plugin persistence module #19698
base: master
Are you sure you want to change the base?
obsidian community plugin persistence module #19698
Changes from all commits
6723c58
7cf942c
77d0292
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting 25 hours sounds a bit excessive, perhaps make this a passive module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, however adding
'Stance' => Msf::Exploit::Stance::Passive,
doesn't make it go background. Not sure if there's a regression somewhere, or it doesn't work withMsf::Exploit::Local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/rapid7/metasploit-framework/pull/19676/files#diff-c85f6f34bf13b244d4ae805595855f8673a1db9be7004e40709827d16cc4747cR39
I actually ran in to this before but didn't feel like dealing with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Framework has an API for executing things properly, such as handling quotes, spaces etc.
This will break if the
path
contains quotes or spaces.mkdir
is the method to use in this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync'ing up on this one, it looks like the scenario of handling win/windows isn't handled
metasploit-framework/lib/msf/core/post/file.rb
Lines 121 to 137 in 2355ab5
Would have to double check if we still have session types with
win
andwindows
in framework, as I can't remember if we standardised the code so that it only appears aswindows
nowadays or notThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per comment on 210, I don't want to use the framework API because of
metasploit-framework/lib/msf/core/post/file.rb
Line 135 in 2355ab5
Also, and I may be mistaken, I believe
metasploit-framework/lib/msf/core/post/file.rb
Line 130 in 2355ab5
cmd.exe /c
, unsure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an unexpected API for sure; not a blocker to this PR - will start a different PR to change that default behavior 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding a function flag defaulting to true to delete should be fine. keeps default behavior, but allows the override for cases like this