Update User Agent strings for October 2024 #19540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
reviewed
Oct 9, 2024
Comment on lines
+9
to
+11
| for x in range(0, len(lines)): | ||
| if replace_marker in lines[x]: | ||
| break |
There was a problem hiding this comment.
Suggested change
| for x in range(0, len(lines)): | |
| if replace_marker in lines[x]: | |
| break | |
| for line in lines: | |
| if replace_marker in line: | |
| break |
There was a problem hiding this comment.
I think this will break the subsequent code when we re-insert it back into the list. We need the index reference to do in-place replacement (unless we also change it to rebuild the list from scratch too).
adfoster-r7
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Thanks for the script; cross-referencing with: #18120
smashery
force-pushed
the
ua_strings_oct24
branch
from
a889ac4 to
395e743
Compare
adfoster-r7
approved these changes
Oct 11, 2024
Release NotesUpdate Metasploit's HTTP request User Agent strings for October 2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a script to automate this in future.
Verification
List the steps needed to make sure this thing works
Check the script in
tools/dev/update_user_agent_strings.pyuser_agent.rbfile and make sure that the script handles it appropriately (usually just a meaningful error message if there's a problem)