Fix empty banner (never set) issue #19059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcintyre-r7
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks, these changes look good to me. I was able to reproduce the original issue and then confirm that the proposed changes fixes it.
metasploit-framework (S:0 J:0) auxiliary(sniffer/psnuffle) > run
[*] Auxiliary module running as background job 0.
metasploit-framework (S:0 J:1) auxiliary(sniffer/psnuffle) >
[*] Loaded protocol POP3 from /home/smcintyre/Repositories/metasploit-framework.pr/data/exploits/psnuffle/pop3.rb...
[*] Sniffing traffic.....
[*] Invalid POP3 Login: 127.0.0.1:51562-127.0.0.1:110 >> foobar / wakawaka ()
[*] Invalid POP3 Login: 127.0.0.1:51562-127.0.0.1:110 >> foobar / ()
[*] Invalid POP3 Login: 127.0.0.1:49550-127.0.0.1:110 >> foobar / waka1 (+OK POP3 Welcome to vm-pop3d 1.1.6 <146.1712592056@bb08d5d5761c>)
[*] Invalid POP3 Login: 127.0.0.1:49550-127.0.0.1:110 >> foobar / (+OK POP3 Welcome to vm-pop3d 1.1.6 <146.1712592056@bb08d5d5761c>)
Release NotesFixes an issue with the psnuffle module's POP3 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #18625