Consolidate session tests #19020
Merged
Consolidate session tests #19020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwelch-r7
force-pushed
the
consolidate-session-tests
branch
2 times, most recently
from
916db9c to
4730194
Compare
|
Looks good to me 👍 We'll probably hold off on this until the postgres/mssql/mysql acceptance tests are in, so we have a way of spotting any issues here |
dwelch-r7
force-pushed
the
consolidate-session-tests
branch
from
4730194 to
6388350
Compare
dwelch-r7
force-pushed
the
consolidate-session-tests
branch
from
6388350 to
434e852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some overlap between tests for the new session types and their clients along with some missing tests so I'm just tidying that all up here in preparation for any additional session types
Verification Steps