Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user affordance for scanner modules that can create a new session #18978

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

dwelch-r7
Copy link
Contributor

@dwelch-r7 dwelch-r7 commented Mar 20, 2024

Adding some messaging to the end of scans to tell the user how many credentials and/or sessions were successful
We can potentially flesh this out further in the future by printing out a table of the good creds/created sessions and extending this more broadly to all scanner types but we've limited the scope to just the login modules for the new SMB, and SQL session types for now

Verification Steps

  • Boot up framework
  • Use the smb_login module
  • Perform a single run against a set of hosts with CreateSession set to false
  • Repeat above but for CreateSession set to true
  • Verify the output messages are correct (correct number of good creds/sessions etc)
  • Repeat for postgres_login, mssql_login and mysql_login

@cgranleese-r7 cgranleese-r7 self-assigned this Mar 20, 2024
@cgranleese-r7 cgranleese-r7 added the rn-enhancement release notes enhancement label Mar 20, 2024
@cgranleese-r7
Copy link
Contributor

Looks good to me 👍

MySQL

Tested against mariadb:11.2.2:
image

MSSQL

Tested against mcr.microsoft.com/mssql/server:2022-preview-ubuntu-22.04:
image

PostgreSQL

Tested against postgres:16.1:
image

SMB

Tested against Windows 10 with multiple valid logins:
image

@cgranleese-r7 cgranleese-r7 merged commit 2a63d0d into rapid7:master Mar 20, 2024
38 checks passed
@cgranleese-r7
Copy link
Contributor

cgranleese-r7 commented Mar 20, 2024

Release Notes

This PR updates several login modules to now display some messaging to the end of scans to tell the user how many credentials and/or sessions were successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants