-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds session documentation #18961
Adds session documentation #18961
Conversation
I think this is missing the changes to the pentesting section of the docs site: https://docs.metasploit.com/docs/pentesting/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comments I have for mssql_login.md
are relevant for the rest as well. Adding as much command line output as we can would help as well I think. So if we talk about a command, add the console interactions output to the markdown.
session within the smb instance. Running the following commands with all other options set: | ||
|
||
``` | ||
set CreateSession true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on maybe adding more steps here on using a login module. I.e copy pasta the full steps so if a user wants to try this then don't have to go elsewhere in the docs to figure out how to use the login modules. I think a single example of lets say mssql_login
would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this already exists below in 'Scenarios' - do you think we should restructure things to make it more cohesive?
The CreateSession option, when set to true, will result in returning an interactive MSSQL session with the target machine | ||
on a successful login: | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding msf6
to all of the Metasploit console examples will give you syntax highlighting 👀
``` | |
```msf6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took another look through this and added some more shuffling I think might make thing clearer. Let me know your thoughts 👍
I added feedback on one markdown again, but it would be relevant to all if you decide to go ahead with the changes.
31b7250
to
e8f71f2
Compare
Will aim to get this in on Monday since we can do docs releases out of band from the normal release cycle |
add more console output, add to pentesting side split out session, help, query, query_interactive sections add multiline examples update mysql, smb
e8f71f2
to
2c307f1
Compare
I think this is a good first step 🎉 We might want to circle back and reduce some of the verbosity in parts, but we'll be able to come back later with fresh eyes and spot what improvements we want to make then |
Release NotesThis PR adds documentation for the new SQL and SMB session types. |
This adds documentation for the SQL/SMB session types. Please let me know if there's anything we need more detail on/should phrase better.