Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BUNDLER_CONFIG_ARGS variable mismatch in Dockerfile #18701

Closed
wants to merge 3 commits into from

Conversation

upsidedwn
Copy link
Contributor

BUNDLER_CONFIG_ARGS was not being used by the bundle config command due to a typo. #18693

This PR is to this issue, however, previous version of Dockerfile used set clean 'true'. However, this no longer works with "newer" versions of Ruby gems (rubygems/rubygems#3271), which now requires a force option when cleaning system gems.

Since there is no way to set the force flag through config, a new ARG (BUNDLER_FORCE_CLEAN) is used to provide the option of whether to run bundle clean --force on system gems.

Previous version of Dockerfile used `set clean 'true'`. However, this no longer works with "newer" versions of Ruby gems (rubygems/rubygems#3271), which now requires a force option when cleaning system gems.

Since there is no way to set the force flag through config, a new ARG (BUNDLER_FORCE_CLEAN) is used to provide the option of whether to run bundle clean --force on system gems.
@smcintyre-r7 smcintyre-r7 added the needs-unique-branch The pull request must not be from the master branch label Feb 14, 2024
Copy link

Thanks for your pull request! We require for all contributed code to come from a from a unique branch in your repository before it can be merged.

Please create a new branch in your fork of framework and resubmit this from that branch.

If you are using Git on the command line that may look like:

# Checkout the master branch
git checkout master

# Create a new branch for your feature
git checkout -b <BRANCH_NAME>

# Add your new files
git add modules/my-cool-new-module

# Commit your changes with a relevant message
git commit

# Push your changes to GitHub
git push origin <BRANCH_NAME>

# Now browse to the following URL and create your pull request!
# - https://github.com/rapid7/metasploit-framework/pulls

This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.

Please do resubmit from a unique branch, we greatly value your contribution! 🎉

@github-actions github-actions bot closed this Feb 14, 2024
@smcintyre-r7
Copy link
Contributor

Hey sorry it took so long to get to this. I looked through it and the code changes look sensible but we need a unique branch in order to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-unique-branch The pull request must not be from the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants