Add File.expand_path to fix no such file error

[gardnerapp]

With issue #18602 a "No such file or directory" error is given when using the -o flag to write the payload to a file. This change uses the FIle.expand_path function to allow for files to be written to the home path of the current user with the ~ character.

Verification

Running the -o option with a file path using ~ now works!

~/metasploit-framework msfconsole
msf6 > reload_all

msf6 > use payload/osx/armle/shell/reverse_tcp 
msf6 payload(osx/armle/shell/reverse_tcp) > set LHOST 10.255.104.146
LHOST => 10.255.104.146
msf6 payload(osx/armle/shell/reverse_tcp) > generate -o ~/payload_test
[*] Writing 1244 bytes to ~/payload_text...

# In a regular shell
$ ls ~/payload*
payload_test

[smcintyre-r7]

Old on the right, new on the left.

There's probably plenty more instances like this. Msfconsole doesn't claim to be a shell like bash or zsh which is what's typically responsible for this type of expansion.

[smcintyre-r7]

Release Notes

This updates the file handling of the generate command's -o parameter to expand file system paths.