Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds wiki guide for session searching #18470

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

zgoldman-r7
Copy link
Contributor

Follow on to #18364

Addresses #18364 (comment) and #18364 (comment)

Verification steps:

  • Look at the wiki and make sure the steps make sense
  • Make sure new test passes
  • Open up a session and do a sessions --search not_a_term:5 and make sure it prints the proper error message

@adfoster-r7
Copy link
Contributor

Looks like the changes are failing:

build.rb:53:in `validate!': Unhandled paths Metasploit-Guide-Session-Search.md - add navigation entries to navigation.rb for these files (Build::ConfigValidationError)
	from build.rb:397:in `run'
	from build.rb:[5](https://github.com/rapid7/metasploit-framework/actions/runs/6580005862/job/17877067312?pr=18470#step:4:6)95:in `run'
	from build.rb:[6](https://github.com/rapid7/metasploit-framework/actions/runs/6580005862/job/17877067312?pr=18470#step:4:7)6[7](https://github.com/rapid7/metasploit-framework/actions/runs/6580005862/job/17877067312?pr=18470#step:4:8):in `<main>'
[!] Validation failed. Please verify navigation.rb is valid, as well as the markdown file

Because new files need to be added to navigation.rb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we move this to be a higher level page:

docs/metasploit-framework.wiki/Managing-Sessions.md

@zgoldman-r7 zgoldman-r7 force-pushed the session-search-fast-follows branch from 0b400f6 to c1c5c95 Compare October 23, 2023 18:06
docs/navigation.rb Outdated Show resolved Hide resolved
Also tweaks an error message

add readme to directory
@zgoldman-r7 zgoldman-r7 force-pushed the session-search-fast-follows branch from c1c5c95 to 8331f4d Compare October 23, 2023 20:34
@adfoster-r7 adfoster-r7 merged commit 96a0426 into rapid7:master Oct 24, 2023
32 checks passed
@adfoster-r7
Copy link
Contributor

Release Notes

Adds a new Wiki page for session management, detailing how to search for sessions and killing stale sessions

@adfoster-r7 adfoster-r7 added rn-documentation release notes for Metasploit Framework documentation and removed enhancement labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs rn-documentation release notes for Metasploit Framework documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants