Update gem dependencies #18432
Merged
Update gem dependencies #18432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
commented
Oct 6, 2023
| @@ -216,7 +216,7 @@ Gem::Specification.new do |spec| | |||
| # SSH server library with ed25519 | |||
| spec.add_runtime_dependency 'hrr_rb_ssh-ed25519' | |||
| # Needed for irb internal command | |||
| spec.add_runtime_dependency 'irb' | |||
| spec.add_runtime_dependency 'irb', '~> 1.7.4' | |||
There was a problem hiding this comment.
irb 1.8 pulls in psych which would cause issues right now; should be able to unpin this once we're officially on Ruby 3.1
adfoster-r7
force-pushed
the
update-gem-dependencies
branch
from
dbbe0e0 to
d11f15b
Compare
adfoster-r7
commented
Oct 6, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| require 'base64' | |||
| require 'openssl' | |||
| require 'net/imap/sasl' | |||
| require 'net/imap' | |||
There was a problem hiding this comment.
Fix autoloading issue
1) Msf::Db::PostgresPR::ScramSha256#normalize returns the expected value for the test {:str=>"\u0627123", :error=>/must start.*end with RandAL/i}
Failure/Error: expect { subject.normalize(test[:str]) }.to raise_error expected_clazz, expected_message
expected Msf::Db::PostgresPR::ScramSha256::NormalizeError with message matching /must start.*end with RandAL/i, got #<NameError: uninitialized constant Net::IMAP::StringPrep> with backtrace:
# ./lib/postgres/postgres-pr/scram_sha_256.rb:64:in `normalize'
# ./spec/lib/postgres/postgres-pr/scram_sha_256_spec.rb:73:in `block (5 levels) in <top (required)>'
# ./spec/lib/postgres/postgres-pr/scram_sha_256_spec.rb:73:in `block (4 levels) in <top (required)>'
# ./spec/lib/postgres/postgres-pr/scram_sha_256_spec.rb:73:in `block (4 levels) in <top (required)>'
dwelch-r7
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gem dependencies, mostly to pull in the cortex metadata - such as rapid7/rex-text#65
Verification
Ensure CI passes