Add history support to nasm and metasm shells #18425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18423
Adds history support to the nasm and metasm shells, which can be found in the
tools/exploit/nasm_shell.rb
directory if installed with the nightly installers - ormsf-metasm_shell
with Kali. Now when re-opening these shells, previously typed commands should be remembered and available.Verification
Before
Crashes (a regression) - but even prior to this commit there was no history functionality
After
All history is remembered; Fresh console:
After re-opening the console, the up/down arrows should navigation history - and
ctrl+r
reverse search should work:The
tools/exploit/nasm_shell.rb
should also work