-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a couple of tips #18412
Add a couple of tips #18412
Conversation
Not a blocker: I'm not sure if the tip's description aligns with the behavior here. If the i.e. this is equally valid as a set of arguments to the
|
@@ -32,13 +32,15 @@ def self.highlight(string) | |||
"Search can apply complex filters such as #{highlight('search cve:2009 type:exploit')}, see all the filters with #{highlight('help search')}", | |||
"Metasploit can be configured at startup, see #{highlight('msfconsole --help')} to learn more", | |||
"Display the Framework log using the #{highlight('log')} command, learn more with #{highlight('help log')}", | |||
"Adapter names can be used for IP params #{highlight('set LHOST eth0')}", | |||
"Network adapter names can be used for IP options #{highlight('set LHOST eth0')}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@adfoster-r7 Do you think it would be more clear to update it to something like: "The 'use' command accepts search queries and will select the module when only a single match is found, e.g. 'use kerberos/get_ticket'". It's more technically accurate but it's a little longer. I think the key here might be that the search query / short hand module name needs to be long enough to uniquely identify it. |
Is "The #{highlight('use')} command supports fuzzy searching, i.e. #{highlight('use kerberos/get_ticket')} or #{highlight('use kerberos forge silver ticket')}" |
f80dd02
to
5aee82e
Compare
Yeah that works, I pushed up a change implementing your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; But will will await Brendan's review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; I added a thought on the use
for shortened or close module names to try and reinforce that it will select the module for you.
Co-authored-by: Brendan <[email protected]>
This should be ready to go now. |
Release NotesThis adds additional usage tips to Metasploit, expanding the pool that is selected from on startup. |
@bwatters-r7 suggested I add the using partial module names to the Metasploit tips trick I was using during my demos over the summer. I also added one for using the capture plugin. If there's another tip suggestion, feel free to leave it as a comment and I'll add it in.
Testing
tips
command and see the new tips show up