Fix broken test suite when running in small console window #18380

adfoster-r7 · 2023-09-18T15:43:36Z

Fixes the test suite from breaking when running the test suite from a small console window

Verification

Before

Test failures:

bundle exec rspec ./spec/lib/msf/core/auxiliary/prometheus_s
pec.rb ./spec/lib/msf/db_manager/export_spec.rb

[...]

Finished in 2.05 seconds (files took 7.66 seconds to load)
57 examples, 14 failures

After

All tests pass

Finished in 2.13 seconds (files took 7.62 seconds to load)
57 examples, 0 failures

adfoster-r7 · 2023-09-19T10:34:23Z

spec/spec_helper.rb

+  #   https://github.com/rapid7/rex-text/blob/11e59416f7d8cce18b8b8b9893b3277e6ad0bea1/lib/rex/text/wrapped_table.rb#L74
+  # This can cause some integration tests to fail if the tests are run from smaller consoles
+  # This mock will ensure that the tests run without word-wrapping.
+  config.before(:each) do


I could have added the console size mocking to just the tests that were currently failing, but I imagined the possibility of someone adding brittle tests again in the future - so I just went with globally mocking things to future proof things.

Fix broken test suite when running in small console window

d71883f

adfoster-r7 commented Sep 19, 2023

View reviewed changes

sjanusz-r7 merged commit 1ef030d into rapid7:master Sep 20, 2023
32 checks passed

adfoster-r7 added the rn-no-release-notes no release notes label Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken test suite when running in small console window #18380

Fix broken test suite when running in small console window #18380

adfoster-r7 commented Sep 18, 2023

adfoster-r7 Sep 19, 2023

Fix broken test suite when running in small console window #18380

Fix broken test suite when running in small console window #18380

Conversation

adfoster-r7 commented Sep 18, 2023

Verification

Before

After

adfoster-r7 Sep 19, 2023

Choose a reason for hiding this comment