Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opt address local crash when ipaddr is nil #18369

Conversation

adfoster-r7
Copy link
Contributor

Fixes the following crash with OptAddressLocal:

  1) Msf::OptAddressLocal behaves like an option with valid values should be valid and normalize appropriately: utun2
     Failure/Error: IPAddr.new(addr)
     
     IPAddr::AddressFamilyError:
       address family must be specified
 

Caused by darwin AF_LINK having an empty string for its addr

Verification

Ensure CI passes

@adfoster-r7 adfoster-r7 force-pushed the fix-opt-address-local-crash-when-ipaddr-is-nil branch from ad25509 to 871e1f4 Compare September 14, 2023 22:10
@cgranleese-r7 cgranleese-r7 self-assigned this Sep 15, 2023
@cgranleese-r7 cgranleese-r7 added the rn-fix release notes fix label Sep 15, 2023
@cgranleese-r7 cgranleese-r7 merged commit ba9f879 into rapid7:master Sep 15, 2023
56 checks passed
@cgranleese-r7
Copy link
Contributor

Release Notes

This PR fixes a crash with OptAddressLocal that was caused by darwin AF_LINK having an empty string for its addr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants