-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Thrift RPC client #18358
Add a Thrift RPC client #18358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to sprinkle in a few unit tests to help future proof things 🙌
Changes look great and testing both modules worked as expected. I'll approve this as is and leave it open for a potential sprinkling of unit tests :) vmware_vrli_rce
nimbus_gettopologyhistory_cmd_exec
|
a56ef8f
to
bf9ef45
Compare
Alright, tests have been added for the data structures. Once they pass, this should be ready to go. Thanks! |
Jenkins test this please |
Release NotesThis adds a new ThriftClient class for interacting with Thrift RPC services. It also updates the two existing Metasploit modules to use it. |
This adds a new ThriftClient class for interacting with Thrift RPC services. It then updates the two existing Metasploit modules to use it. It also includes additional type definitions, allowing the updated modules to define their data instead of using opaque blobs.
Both exploits were retested to ensure they're still functioning correctly.