Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kibana Timelion Prototype Pollution RCE (CVE-2019-7609) #18316
Kibana Timelion Prototype Pollution RCE (CVE-2019-7609) #18316
Changes from 3 commits
5382eb2
b529814
db9bf5f
c6a2652
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to add a
on_new_session
method with this code? This method is called when a new session is established. This might be the place to execute this and stop the raining shells. For example, this is untested and probably not working, but just to get the idea:Another idea would be to keep the "reset" code in both
exploit
andon_new_session
to make sure the reset is sent even if something went wrong. Maybe an instance variable can be used and set inon_new_session
when the reset is done. The code inexploit
can check this instance variable and decide to sent the reset request after a certain amount of time.For example (still untested):
There is probably a lot of race condition issues here, but you get the idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's one big race.... Depending on the speed of the computer, I definitely see more or less shells. A VM will give me 10, an i7 laptop will give me 40. (this is down from 40 and 100).
So I think @sempervictus 's original idea was too fast, it set it and unset before the payload had a chance to trigger. I think unsetting
on_new_session
is a good idea, but at that point its too late as its kicked off a ton of times. I like the idea of doing the@reset_done
checks and trying to fire ASAP, so I'll take that. However, the (good?) problem still exists of many shells.