Fix #17969 Assign empty hash to variable status

[YiDa858]

Assign a nil value to the variable status to fix issue #17969

[bcoles]

This fixes the crash although is unlikely to fix the underlying issue.

What caused a code path with a nil status to be reached?

[YiDa858]

The variable is assigned in the loop. When the loop ends, status['status'] will be accessed.
If I don't assign the variable before the loop begin, status['status'] is always undefined according to the output.

[gwillcox-r7]

@YiDa858 Any update on implementing the suggested fix from @cdelafuente-r7 and testing it out?

[sjanusz-r7]

I've implemented the suggested change nil -> {}.

nessus_db_import

Before (throws):

msf6 > nessus_scan_list -c
Scan ID  Name                    Owner  Started  Status     Folder
-------  ----                    -----  -------  ------     ------
5        My Host Discovery Scan  msf             canceled   3
8        My Basic Network Scan   msf             canceled   3
14       MyNewScan               msf             completed  3

msf6 > nessus_db_import 14
[*] Exporting scan ID 14 is Nessus format...
[+] The export file ID for scan ID 14 is 940963288
[*] Checking export status...
[*] Export status: loading
[*] Export status: ready
[-] Error while running command nessus_db_import: undefined local variable or method `status' { ... }

After (works):

msf6 > nessus_scan_list -c
Scan ID  Name                    Owner  Started  Status     Folder
-------  ----                    -----  -------  ------     ------
5        My Host Discovery Scan  msf             canceled   3
8        My Basic Network Scan   msf             canceled   3
14       MyNewScan               msf             completed  3

msf6 > nessus_db_import 14
[*] Exporting scan ID 14 is Nessus format...
[+] The export file ID for scan ID 14 is 1751507142
[*] Checking export status...
[*] Export status: loading
[*] Export status: ready
[*] The status of scan ID 14 export is ready
[*] Importing scan results to the database...
[*] Importing data of 192.168.207.132
[+] Done

nessus_scan_export

Before (throws):

msf6 > nessus_scan_export 14 'Nessus'
[+] The export file ID for scan ID 14 is 1254750517
[*] Checking export status...
[*] Export status: loading
[*] Export status: ready
[-] Error while running command nessus_scan_export: undefined local variable or method `status' { ... }

After (works):

msf6 > nessus_scan_export 14 'Nessus'
[+] The export file ID for scan ID 14 is 187847318
[*] Checking export status...
[*] Export status: loading
[*] Export status: ready
[+] The status of scan ID 14 export is ready

[sjanusz-r7]

Release Notes

Fixed an error in nessus_db_import and nessus_scan_export commands that prevented them from completing successfully.