Merge pull request #19659 from sjanusz-r7/fix-irb-deadlock-error

Fix IRB deadlock recursive locking on Ctrl+C
rapid7 · Nov 19, 2024 · e6615d3 · e6615d3
2 parents 1d7e605 + bc45734
commit e6615d3
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/lib/rex/ui/text/irb_shell.rb b/lib/rex/ui/text/irb_shell.rb
@@ -40,20 +40,18 @@ def run
     IRB.conf[:MAIN_CONTEXT] = irb.context
 
     # Trap interrupt
-    old_sigint = trap("SIGINT") do
-      begin
+    begin
+      old_sigint = trap("SIGINT") do
         irb.signal_handle
-      rescue RubyLex::TerminateLineInput
-        irb.eval_input
       end
-    end
 
-    # Keep processing input until the cows come home...
-    catch(:IRB_EXIT) do
-      irb.eval_input
+      # Keep processing input until the cows come home...
+      catch(:IRB_EXIT) do
+        irb.eval_input
+      end
+    ensure
+      trap("SIGINT", old_sigint) if old_sigint
     end
-
-    trap("SIGINT", old_sigint)
   end
 
 end