Land #18403, Fix FileDropper to properly clone string variables befor…

…e storing them
rapid7 · Oct 25, 2023 · 93645c2 · 93645c2
2 parents a503152 + 0b7a1bf
commit 93645c2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/msf/core/exploit/file_dropper.rb b/lib/msf/core/exploit/file_dropper.rb
@@ -40,7 +40,7 @@ def initialize(info = {})
   #   exploiting).
   # @return [void]
   def register_files_for_cleanup(*files)
-    @dropped_files += files
+    @dropped_files += files.map(&:dup)
   end
 
   def allow_no_cleanup
@@ -56,7 +56,7 @@ def allow_no_cleanup
   #   exploiting).
   # @return [void]
   def register_dirs_for_cleanup(*dirs)
-    @dropped_dirs += dirs
+    @dropped_dirs += dirs.map(&:dup)
   end
 
   # Singular versions