Fix removing initialize warnings

rapid7 · Feb 2, 2024 · 23e184c · 23e184c
1 parent 35778e9
commit 23e184c
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/spec/lib/metasploit/framework/login_scanner/mssql_spec.rb b/spec/lib/metasploit/framework/login_scanner/mssql_spec.rb
@@ -83,8 +83,8 @@
       let(:client) { instance_double(Rex::Proto::MSSQL::Client) }
       it 'returns a result with the connection_error status' do
         my_scanner = login_scanner
-        allow_any_instance_of(Rex::Proto::MSSQL::Client).to receive(:initialize).and_return(client)
-        allow_any_instance_of(Rex::Proto::MSSQL::Client).to receive(:mssql_login).and_raise ::Rex::ConnectionError
+        allow(Rex::Proto::MSSQL::Client).to receive(:new).and_return(client)
+        allow(client).to receive(:mssql_login).and_raise ::Rex::ConnectionError
         allow(client).to receive(:disconnect)
         expect(my_scanner.attempt_login(pub_blank).status).to eq Metasploit::Model::Login::Status::UNABLE_TO_CONNECT
       end
@@ -94,8 +94,8 @@
       let(:client) { instance_double(Rex::Proto::MSSQL::Client) }
       it 'returns a result object with a status of Metasploit::Model::Login::Status::INCORRECT' do
         my_scanner = login_scanner
-        allow_any_instance_of(Rex::Proto::MSSQL::Client).to receive(:initialize).and_return(client)
-        allow_any_instance_of(Rex::Proto::MSSQL::Client).to receive(:mssql_login).and_return(false)
+        allow(Rex::Proto::MSSQL::Client).to receive(:new).and_return(client)
+        allow(client).to receive(:mssql_login).and_return(false)
         allow(client).to receive(:disconnect)
         expect(my_scanner.attempt_login(pub_blank).status).to eq Metasploit::Model::Login::Status::INCORRECT
       end
@@ -105,12 +105,11 @@
       let(:client) { instance_double(Rex::Proto::MSSQL::Client) }
       it 'returns a result object with a status of Metasploit::Model::Login::Status::SUCCESSFUL' do
         my_scanner = login_scanner
-        allow_any_instance_of(Rex::Proto::MSSQL::Client).to receive(:initialize).and_return(client)
-        allow_any_instance_of(Rex::Proto::MSSQL::Client).to receive(:mssql_login).and_return(true)
+        allow(Rex::Proto::MSSQL::Client).to receive(:new).and_return(client)
+        allow(client).to receive(:mssql_login).and_return(true)
         allow(client).to receive(:disconnect)
         expect(my_scanner.attempt_login(pub_blank).status).to eq Metasploit::Model::Login::Status::SUCCESSFUL
       end
     end
   end
-
 end