This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Add possibility of having project files in different locations than root, when packaging webos project #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility of copying subdirectories into our project
ex [package.json]:
"react-tv": {
"files": [
"./public/index.html",
"./dist/bundle.js",
"./dist/assets/"
]
}
./public/index.html file will be copied to [webos_project_root]/index.html
./dist/bundle.js file will be copied to [webos_project_root]/bundle.js
./dist/assets/ dir and it's content will be copied to [webos_project_root]/assets
note 1) in this change, .npmignore was not implemented
note 2) If you add a directory that stand on the root, it will not work. ex:
"react-tv": {
"files": [
"./public/index.html",
"./dist/bundle.js",
"./dist/assets/",
"./videos/"
]
}
This was not implemented cause may cause corruption of our default webos_project files, like appinfo.json or even the [].ipk file itself. Problem it could be implemented when the .npmignore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility of copying subdirectories into our project
ex [package.json]:
"react-tv": {
"files": [
"./public/index.html",
"./dist/bundle.js",
"./dist/assets/"
]
}
./public/index.html file will be copied to [webos_project_root]/index.html
./dist/bundle.js file will be copied to [webos_project_root]/bundle.js
./dist/assets/ dir and it's content will be copied to [webos_project_root]/assets
note 1) in this change, .npmignore was not implemented
note 2) If you add a directory that stand on the root, it will not work. ex:
"react-tv": {
"files": [
"./public/index.html",
"./dist/bundle.js",
"./dist/assets/",
"./videos/"
]
}
This was not implemented cause may cause corruption of our default webos_project files, like appinfo.json or even the [].ipk file itself. Problem it could be implemented when the .npmignore.