-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish Factorio UX #7494
Polish Factorio UX #7494
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7494 +/- ##
==========================================
- Coverage 85.09% 85.07% -0.03%
==========================================
Files 693 694 +1
Lines 42940 42970 +30
Branches 5206 5210 +4
==========================================
+ Hits 36541 36556 +15
- Misses 5243 5257 +14
- Partials 1156 1157 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
("Is Factorio: Space Age supported?", "No."), | ||
("Are other mods supported?", "Only mods that don't add new researches are compatible."), | ||
( | ||
"Is multiplayer supported?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth it to clarify "built-in multiplayer"? just to avoid confusion between factorio multiplayer and mw/coop
"The recipes for rocket parts", | ||
], | ||
need_to_play=[ | ||
"A copy of the game from Steam or Factorio.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
factorio.com
instead?
Also CC @duncathan for whether website allows markdown. I don't think so, but it may allow html?
based off of looking at it here: https://github.com/randovania/randovania.github.io/blob/418a7ab39ab408d1740ec35376426def44954d1a/_layouts/game.html#L42
<property name="text"> | ||
<string><html><head/><body><p>In order to create the randomizer mod, a copy of Factorio itself is needed.</p></body></html></string> | ||
<string><html><head/><body><p>If playing from Steam, press &quot;Use default&quot;. On Linux, if using Flatpak Steam the default won't work.<br/>If you downloaded directly from Factorio.com, there will be a mods folder after opening the game once.</p></body></html></string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this a markdown label and then use factorio.com as a hyperlink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really any need. we're not directing people to the site, just identifying it
d0164e9
to
d9702f0
Compare
The actual mod downloading will be handled in https://github.com/randovania/factorio-randovania-mod/.