Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Factorio UX #7494

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Polish Factorio UX #7494

merged 8 commits into from
Nov 19, 2024

Conversation

henriquegemignani
Copy link
Member

image
image
image

The actual mod downloading will be handled in https://github.com/randovania/factorio-randovania-mod/.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.07%. Comparing base (217aace) to head (d9702f0).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ia/games/factorio/gui/dialog/game_export_dialog.py 27.77% 13 Missing ⚠️
randovania/gui/tracker_window.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7494      +/-   ##
==========================================
- Coverage   85.09%   85.07%   -0.03%     
==========================================
  Files         693      694       +1     
  Lines       42940    42970      +30     
  Branches     5206     5210       +4     
==========================================
+ Hits        36541    36556      +15     
- Misses       5243     5257      +14     
- Partials     1156     1157       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

("Is Factorio: Space Age supported?", "No."),
("Are other mods supported?", "Only mods that don't add new researches are compatible."),
(
"Is multiplayer supported?",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth it to clarify "built-in multiplayer"? just to avoid confusion between factorio multiplayer and mw/coop

"The recipes for rocket parts",
],
need_to_play=[
"A copy of the game from Steam or Factorio.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factorio.com instead?
Also CC @duncathan for whether website allows markdown. I don't think so, but it may allow html?
based off of looking at it here: https://github.com/randovania/randovania.github.io/blob/418a7ab39ab408d1740ec35376426def44954d1a/_layouts/game.html#L42

randovania/gui/dialog/game_export_dialog.py Show resolved Hide resolved
<property name="text">
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;In order to create the randomizer mod, a copy of Factorio itself is needed.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;If playing from Steam, press &amp;quot;Use default&amp;quot;. On Linux, if using Flatpak Steam the default won't work.&lt;br/&gt;If you downloaded directly from Factorio.com, there will be a mods folder after opening the game once.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a markdown label and then use factorio.com as a hyperlink

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really any need. we're not directing people to the site, just identifying it

@henriquegemignani henriquegemignani added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 666be7b Nov 19, 2024
20 of 21 checks passed
@henriquegemignani henriquegemignani deleted the feature/factorio-polish branch November 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants