Add minimal guide regarding input validation #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miepee
requested changes
Dec 2, 2024
|
|
||
| ## Metroid Prime and Metroid Prime 2: Echoes | ||
|
|
||
| Both games only support the GameCube versions of the game, with uncompressed files in the ISO format. |
There was a problem hiding this comment.
Mention that you can use dolphin to verify your input ISO (right click the game -> properties -> verify tab -> verify integrity button)
Also the user should have acccess to the clean hashes so they know they have a good dump (can probably copy paste them from the rdv repo)
There was a problem hiding this comment.
I don't want to have the hashes duplicated here, that seems terrible
There was a problem hiding this comment.
could maybe get the hashes dynamically here somehow, would need to ask dunc
But the end user should be able to see the clean supported hashes here for UX purposes.
Miepee
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.