Use new BMSSD API #489
Draft
Use new BMSSD API #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanatosGit
commented
Dec 23, 2024
| ], | ||
| # Beam Burst Shot Blocks | ||
| "s030_area3": [ | ||
| {"block_group": 5, "cc": ["036"], "vignette_models": [1239739760, 2986218869]}, | ||
| {"block_group": 5, "names_or_ids": [1239739760, 2986218869]}, |
There was a problem hiding this comment.
Maybe we change all model ids to the model names like I did for s010_area1?
There was a problem hiding this comment.
Does everything have a name? Then probably do that since it'd be easier to follow
There was a problem hiding this comment.
Yes, besides the single one for ItemType.OBJECT which can only be accessed via index according to our BMSSD api.
see https://github.com/ThanatosGit/mercury-engine-data-structures/blob/688960804b5fe00d6236f6624c44a6efa5fbdbb5/src/mercury_engine_data_structures/formats/bmssd.py#L236
There was a problem hiding this comment.
Ok, then let's use the name wherever possible. It's far more readable that way then a bunch of numbers imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New MEDS is not compatible with our
disable_vignettes.But new MEDS version is not usable.
Either we fix it differently for new MEDS or just do another new MEDS with this: randovania/mercury-engine-data-structures#256