Improve crumble block removal patches #465
Conversation
for more information, see https://pre-commit.ci
|
But why?
|
|
My thought was it's cleaner in game as it actually removes the blocks lolenthe patches say, but I guess it's also a bit overkill for what it's doing. I can close this. |
|
You could say that maybe it is more intuitive for people who play the rando for the first time and they didnt read the default settings. |
| bmssd = editor.get_file(f"maps/levels/c10_samus/{scenario_name}/{scenario_name}.bmssd", Bmssd) | ||
| for objects in object_group: | ||
| # Disable the blocks | ||
| bmsbk.raw["collision_cameras"][objects["cc_idx"]]["entries"].pop(objects["entry_idx"]) |
There was a problem hiding this comment.
I don't know all these files by heart but pop looks like it is removing something instead of disable them?
There was a problem hiding this comment.
Yeah removing them from the "master list" makes them not exist.
| _update_blocks(editor, object_group, scenario_name) | ||
|
|
||
|
|
||
| def _update_blocks(editor: PatcherEditor, object_group: typing.Any, scenario_name: str) -> None: |
There was a problem hiding this comment.
_remove_blocks maybe?
I always think that patch, update etc. is changing something instead of completly removing something.
Well, but I guess that remove is also kind of an update.
|
I'm honestly unsure at this point if this is even worth doing. I'll leave this PR open for the time being. |
|
Decided this isn't worth doing at the moment. Could always revisit in the future depending on if we want to make an API to make edits for any block we want. |
Completely removes the blocks if the configurations are set, instead of having them never respawn.
Surface
Area 1
Fixes #427