New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2nd Attempt at fixing `required_dna` compatibility #449

Merged

ThanatosGit merged 2 commits into main from required-dna-fix-#2

Aug 3, 2024

Collaborator

dyceron commented Aug 3, 2024 •

edited

Loading

Reworks how required_dna is handled to ensure all patcher jsons are compatible.

Removes the default value from the schema
Checks for the new configuration field in the json
- If it exists, set the value of required_dna to it (new jsons)
- If it doesn't exist, take the difference of 39 and the starting DNA to calculate the required DNA (old jsons)


          2nd Attempt at fixing required_dna compatibility

510352c

dyceron requested a review from ThanatosGit

August 3, 2024 04:28


          Use inventory instead of final inventory for a shorter iteration

d076eec

ThanatosGit approved these changes

View reviewed changes

ThanatosGit merged commit 762fe7c into main

7 checks passed

ThanatosGit deleted the required-dna-fix-#2 branch

August 3, 2024 05:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet