Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I lied in the other PR. I just looked into the code. We return a generator via
yield
in the function.It's a pretty bad idea to use a
cache
on a generator because it will return the same generator multiple times but we iterate through it, so the generator is already exhausted after first loop.Or short: This code is only executed once and not for all required scenarios.
I switched to return a list instead.
Should have seen this when I initially reviewed it. Stupid me, sorry. :(
But better to not include for the next release.
Fix #435