Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert caching get_asset_names_in_folder #436

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Revert caching get_asset_names_in_folder #436

merged 1 commit into from
Jul 29, 2024

Conversation

dyceron
Copy link
Collaborator

@dyceron dyceron commented Jul 28, 2024

The caching causing memory errors in scenarios without a Chozo Seal present, where a custom DNA Seal has been added. This has a side effect of the patcher being ~1-2 seconds slower than before.

Related to #435

@dyceron
Revert "Merge pull request #415 from randovania/feature/cache-get-ass…
91b39d1 
…et-names"

This reverts commit c564a93, reversing
changes made to d88582c.
@dyceron dyceron requested review from Miepee and ThanatosGit July 28, 2024 15:29
ThanatosGit
ThanatosGit approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be too hard to readd it because imo it could only be a problem if we add new things in between. Just need to make sure to add everything in the beginning.

@ThanatosGit ThanatosGit merged commit 47fb704 into main Jul 29, 2024
7 checks passed
dyceron pushed a commit that referenced this pull request Jul 29, 2024
@ThanatosGit @dyceron
Merge pull request #436 from randovania/revert-cache
2c3032b 
Revert caching `get_asset_names_in_folder`
@dyceron dyceron deleted the revert-cache branch August 11, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThanatosGit ThanatosGit ThanatosGit approved these changes

@Miepee Miepee Awaiting requested review from Miepee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyceron @ThanatosGit