Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface West Music Changes #407

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Surface West Music Changes #407

merged 1 commit into from
Jul 10, 2024

Conversation

dyceron
Copy link
Collaborator

@dyceron dyceron commented Jul 10, 2024

Update the music in Surface West to be Surface East 1 if DNA is not 39 and Baby is not collected, and then uses the regular theme once the conditions to access Ridley are met. The reason for doing this is to add yet another indicator if the seed can be finished.

Debated on doing the 2nd Surface theme to indicate its a later area, but I think the first theme fits better since Landing Site uses that theme.

@dyceron dyceron requested a review from ThanatosGit July 10, 2024 06:36
Copy link
Collaborator

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without looking it up, I have no idea what all the parameters are.
As long as they do "stop the currently played stream and loop the new one" it lgtm.

@dyceron
Copy link
Collaborator Author

dyceron commented Jul 10, 2024

I pretty much just copied the music function call from a7 for the omegas and changed the the track and conditional and it works. When the conditions are met in surface west, the music stops and loads the new track.

@dyceron dyceron merged commit 66d579d into main Jul 10, 2024
7 checks passed
@dyceron dyceron deleted the update-surface-west-music branch July 22, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants