Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable low poly Samus if reloading from checkpoint during boss fight #406

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

dyceron
Copy link
Collaborator

@dyceron dyceron commented Jul 10, 2024

OnPlayerDead already handles disabling the low poly on death, but reloading from checkpoint while in a boss fight is not handled in vanilla. This ensures low poly is disabled when a scenario load happens.

Fixes #317

@dyceron dyceron requested a review from ThanatosGit July 10, 2024 00:37
Copy link
Collaborator

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you reload to save but the save is not in one of the 3 areas?

@dyceron
Copy link
Collaborator Author

dyceron commented Jul 10, 2024

Ah that's a good point. I wonder if it's possible to generalize this and add it to the scenario.lua` instead?

@ThanatosGit
Copy link
Collaborator

Sounds fine if reloading to save is really an issue. I assume it because the low poly stuff seems to be a "play session wide global".
Thinking about it, now I'm curious what happens currently if you go with gravity to Diggernaut and then reload to a save without gravity. Invisible Samus until you pick up gravity again?

@dyceron
Copy link
Collaborator Author

dyceron commented Jul 10, 2024

Just tested swapping from low poly grav to power and power was normal, the switching back to gravity was normal poly.

For reloading save or warp to start in another scenario
@dyceron
Copy link
Collaborator Author

dyceron commented Jul 10, 2024

Figured out how to disable when leaving scenarios in the last commit

@dyceron dyceron requested a review from ThanatosGit July 10, 2024 05:21
Copy link
Collaborator

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's nice. Didn't now that this exists.

@dyceron dyceron merged commit b095f6d into main Jul 10, 2024
7 checks passed
@dyceron dyceron deleted the reset-low-poly branch July 10, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reloading from Checkpoint while in Diggernaut fight doesnt reset low poly model
2 participants