Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint for Baby location on collected all DNA textbox #387

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

dyceron
Copy link
Collaborator

@dyceron dyceron commented Jun 25, 2024

Reads a string from the configuration which replaces the second sentence with a Baby hint. Will be configurable in Randovania to choose between no hint (current behavior), area only, or precise. Useful as a last resort if in go mode otherwise, or if a Baby hint is not provided

image

@dyceron dyceron requested a review from ThanatosGit June 25, 2024 02:58
@dyceron
Copy link
Collaborator Author

dyceron commented Jun 25, 2024

I'm pretty sure the schema is wrong.

Copy link
Collaborator

@ThanatosGit ThanatosGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that both is in the hints array?
The usage in src/open_samus_returns_rando/specific_patches/hint_patches.py is now "Process everything besides baby hint" and in src/open_samus_returns_rando/lua_editor.py it's "Process nothing besides baby hint".
It looks like it shouldn't be in the same object at all.

@dyceron
Copy link
Collaborator Author

dyceron commented Jun 25, 2024

It's in hints for simplicity. I was just basing this on how the export would be in the PDF in RDV to avoid duplicating things. Though I guess I'm already doing that by adding the Baby hint so that's irrelevant.

The other changes follow suit, but this is making this harder. I guess it'd be much easier and simpler to have another field in the config instead of grouping it.

@dyceron dyceron requested a review from ThanatosGit June 25, 2024 03:26
@dyceron
Copy link
Collaborator Author

dyceron commented Jun 25, 2024

Moved the hint to its own field for simplicity

@dyceron dyceron merged commit f8efa74 into main Jun 25, 2024
7 checks passed
@dyceron dyceron deleted the baby-hints branch June 25, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants